|
From: Szakacsits S. <sz...@si...> - 2004-02-26 13:32:30
|
On Thu, 26 Feb 2004, Anton Altaparmakov wrote: > On Thu, 2004-02-26 at 11:21, Szakacsits Szabolcs wrote: > > Adding NTFS 3.1 support would be also wonderful. There aren't many changes > > compared to NTFS 1.2 and this could help _a lot_ to make (automatic) > > testing and development easier. There wouldn't be need to get XP images, > > we could create whenever we need. > > Huh? I never added NTFS 3.x support because any form of Windows 2k or > later will just upgrade the volume on mount so it seems silly to have > mkntfs more complicated. It's not silly. First of all I can not confirm you're right that all Win versions, in all cases will upgrade from 1.2 to 3.x. Maybe you only tried an NT4 -> W2K upgrade and in that case it make sense to upgrade NTFS but not otherwise, as I've seen several times. Secondly and most importantly, you _need_ Windows to do this. And that's silly :-) > Oh yes, the dest[i] at the bottom... The 3rd solution is still not > correct though. My point was the buffer overflow, not the technical detail how to handle it. > > > > * @param dst [out] points the buffer to receive the unicode string > > > > * @param src [in] points the char string to be converted > > > > * @param size [in] size of the @dst buffer in bytes > > > > The [in|out]'s are _very_ important. I also always missed them. > > Fair enough, we can add them but we can still please use this form: > > @dst: description [OUT] > @src: description2 [IN] > @size: description3 [IN] [IN|OUT] in the end is obfuscated and against the general conventions. > Also is @dst really [OUT]? To me it seems like @dst is [IN] but *@dst > is [OUT]... Modified directly, indirectly, struct members, etc. It's based on common sense but maybe it's also written somewhere :) > I hate this [IN] and [OUT] stuff but if you like them feel free to add > them but _please_ at the end of the lines so I can just ignore them when > reading... That's very important who reads it. If only you then you're right. If others also then their opinion might count as well if you're interested to get some help ;) Szaka |
