|
From: Szakacsits S. <sz...@si...> - 2005-08-01 20:37:14
|
Hi Yura, On Fri, 29 Jul 2005, Yura Pakhuchiy wrote: > On Fri, 2005-07-29 at 17:31 +0200, Szakacsits Szabolcs wrote: > > On Fri, 29 Jul 2005, Yura Pakhuchiy wrote: > > > > > > I don't think so. We should return EIO on real errors (eg. damaged > > > volume), but unclean logfile it's not damaged volume, it's simply case > > > that we don't support yet. So I think that EOPNOTSUPP is absolutely > > > correct here. Please also note that EOPNOTSUPP == ENOTSUP, which is used in quite many places in libntfs already. > > You converted all ntfs_check_logfile() and ntfs_is_logfile_clean() error > > cases to EOPNOTSUPP. Damaged volumes too. > > Yes, because this functions check consistency of logfile content, even > if it's absolutely invalid it's not a damaged volume. On damaged volumes > we will receive error much earlier, during previous steps of mount, > ntfs_inode_open for logfile or ntfs_attr_open. Well, anyway, maybe it's still better because I've never met ENOTSUP from ntfs_mount so we could now distinguish immediately this error case from all the others. Szaka |
