|
From: Yura P. <pak...@ip...> - 2005-07-29 15:40:00
|
On Fri, 2005-07-29 at 17:31 +0200, Szakacsits Szabolcs wrote:
> On Fri, 29 Jul 2005, Yura Pakhuchiy wrote:
> > On Fri, 2005-07-29 at 16:58 +0200, Szakacsits Szabolcs wrote:
> > > On Fri, 29 Jul 2005, Yura Pakhuchiy wrote:
> > >
> > > > - if (ntfs_check_logfile(na) && ntfs_is_logfile_clean(na))
> > > > - ret = 0;
> > > > - else {
> > > > - ret = -1;
> > > > - err = EIO;
> > > > - }
> > > > + if (!ntfs_check_logfile(na) || !ntfs_is_logfile_clean(na))
> > > > + err = EOPNOTSUPP;
> > >
> > > I don't like this very much. Now users would get the message that mounting
> > > NTFS is not supported and that's pretty bogus. EIO covered the issue much
> > > more better.
> >
> > I don't think so. We should return EIO on real errors (eg. damaged
> > volume), but unclean logfile it's not damaged volume, it's simply case
> > that we don't support yet. So I think that EOPNOTSUPP is absolutely
> > correct here.
>
> You converted all ntfs_check_logfile() and ntfs_is_logfile_clean() error
> cases to EOPNOTSUPP. Damaged volumes too.
Yes, because this functions check consistency of logfile content, even
if it's absolutely invalid it's not a damaged volume. On damaged volumes
we will receive error much earlier, during previous steps of mount,
ntfs_inode_open for logfile or ntfs_attr_open.
--
Best regards,
Yura
|
