|
From: Szakacsits S. <sz...@si...> - 2005-06-21 22:18:09
|
On Tue, 21 Jun 2005, Yura Pakhuchiy wrote: > > I thought this patch was quite small and obvious. The length and complexity of the patches are irrelevant from the log message's point of view. Expressive log messages help readers better understand what's going on in the project even without looking or understanding the relevant code and also help peer developers to revise the patches. > OK, fixed message will look like: "ntfscp: SIGINT was handled, > but printf was about SIGTERM. Now handle both and print respective > message." Wonderful! :-) BTW, printf isn't signal-safe, it can't be used in signal handlers. Szaka |
