On Tue, 21 Jun 2005, Yura Pakhuchiy wrote:
> On Tue, 2005-06-21 at 22:12 +0300, Szakacsits Szabolcs wrote:
> > On Tue, 21 Jun 2005, Yura Pakhuchiy wrote:
> > > Log Message:
> > > ntfscp: Fix signal handling.
> >
> > [ ... once earlier .... ]
> >
> > > Update attribute definition handling.
> >
> > Please include in the log message what _exactly_ you fix, update. In itself
> > these messages don't have really useful information. Additionally it's much
> > easier and faster to check changes if we know what one really intend to fix
> > or update.
>
> I thought this patch was quite small and obvious. If no, sorry, anyway I
> didn't think that somebody watching for changes to ntfscp. OK, fixed
> message will look like: "ntfscp: SIGINT was handled, but printf was
> about SIGTERM. Now handle both and print respective message."
>
> About "Update attribute definition handling.": this commit was ported
> from kernel driver, and commit message I cut-n-pasted from Anton's
> commit message.
Yes, my commit messages are not always very good. Sorry about that. )-:
Best regards,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
|