|
From: Christian B. <br...@ke...> - 2024-04-16 10:39:17
|
On Mon, Apr 15, 2024 at 06:06:03PM +0200, Johan Hovold wrote: > On Mon, Apr 15, 2024 at 08:51:13AM -0700, Linus Torvalds wrote: > > On Mon, 15 Apr 2024 at 08:47, Johan Hovold <jo...@ke...> wrote: > > > > > > I think the "ntfs" alias must always be mounted read-only because you > > > can currently have an fstab entry which does not specify "ro" and this > > > mount would suddenly become writeable when updating to 6.9 (possibly by > > > a non-privileged user, etc). > > > > Well, it would be fairly easy to do particularly if we just do it for > > the old legacy case. > > > > Of course, even the legacy case had that CONFIG_NTFS_RW option, so > > people who depended on _that_ would want to be able to remount... > > Ah, right, I forgot about CONFIG_NTFS_RW as I've never enabled it. > > Judging from the now removed Kconfig entry perhaps not that many people > did: > > The only supported operation is overwriting existing files, > without changing the file length. No file or directory > creation, deletion or renaming is possible. > > but I guess it still makes my argument above mostly moot. > > At least if we disable write support in ntfs3 by default for now... I think we can disable write support in ntfs3 for now. I've picked up the patch to make ntfs3 serve I sent some time ago that Johan tested now. The only thing left is to disable write support for ntfs3 as legacy ntfs driver for now. I took a stab at this. The following two patches I'm appending _should_ be enough iiuc. Johan, please take a look and please test. This is also available on: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.fixes So feel free to pull from there and look there as well. |
