On Fri, 28 Mar 2003, Philipp Thomas wrote:
> * Szakacsits Szabolcs (sz...@si...) [20030328 19:48]:
>
> > What you really mean is
> >
> > le32_to_cpu(ie->_IIF(index_length))
> >
> > Yes, it's not very nice. How about this?
> >
> > ntfs_get_index_length(ie)
>
> IMO that's a much better :) That way you encapsulate the hairy details and
> make the code much more readable.
Yes, _moreover_ it would make
- compilation possible with older compilers
- compilation possible with broken compilers
- Richard Henderson happy
- usage of unusual/unused/unreliable "ms-extension" option unneeded
There is also a new bug submitted to the ODSL Kernel Bug Tracker, NTFS
driver can't be compiled on the newest SuSE 8.2 with gcc 3.3-pre [default
compiler?]. I didn't check it out but apparently it's also due to this
never ending issue ...
http://bugme.osdl.org/show_bug.cgi?id=607
Szaka
|