|
From: Philipp T. <pt...@su...> - 2003-03-28 17:50:38
|
* Anton Altaparmakov (ai...@ca...) [20030328 12:44]:
> How about you show me a snippet of what you propose it to look like, i.e.
> send me a patch that changes layout.h to your proposal (no need to change
> the rest of the driver yet).
Here's the patch for layout.h. With this, the driver is compilable without
any further changes. I also tested the 2.95.3 path by changing the test
in types.h to a simple '#if 1'. BTW, if you don't like
@@ -2037,7 +2037,7 @@ typedef struct {
/* sizeof() = 16 bytes */
} __attribute__ ((__packed__)) INDEX_ENTRY_HEADER;
-#define _IIF(X) SC(ieh.iif,X)
+#define _IIF(X) _IEH(SC(iif,X))
#define _IEV(X) SC(iif.iev,X)
We'd need something like
#if __GNUC__ < 3
# define SC2(P1,P2,N) P1.P2.N
#else
# define SC2(P1,P2,N) P1.N
#endif
#define _IIF(X) SC2(ieh,iif,X)
Though looking at the macro mess needed to support gcc < 3.0 I'd rather drop
the use of unnamed structs/unions until the kernel drops support for gcc <
3.0, as something like ie->_IIF(index_length) is really hard to read and not
exactly what I'd call intuitive.
Philipp
2003-03-28 Philipp Thomas <pt...@su...>
* layout.h: Remove the use of unnamed typedef'd structs and
adapt the accessor macros accordingly.
--
Philipp Thomas <pt...@su...>
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nuremberg, Germany
|
