|
From: Szakacsits S. <sz...@si...> - 2002-07-12 13:02:21
|
On Thu, 11 Jul 2002, Anton Altaparmakov wrote: > At 14:18 11/07/02, Szakacsits Szabolcs wrote: > >However ntfsfix also accepts any version 2.X. Does that really needed? > Yeah, Please adapt your function to accept all 2.x versions, too. (And Commited. > >I also plan to move log journal reset and > > Please, only one argument: ntfs_volume *vol, function does rest. Also, > please don't use the code from ntfsfix and instead use ntfs_open_inode() + > ntfs_open_attr() [you now know the size] + loop using ntfs_attr_pwrite() > with a 4kiB or so buffer which is memset to -1 over the length of the > attribute + close the attr and the inode. I have been meaning to do this > for ages but never got round to it and ntfs_attr_pwrite() was not advanced > enough back then, but it is now... Thanks! (-: Commited. My md5sum's matched with old and the new ntfsfix but please test it. > Further I think the journal emptying should actually happen at ntfs_mount() > time, perhaps we could have a mount option to prevent this from happening? > Although I don't see why would want to prevent it, so probably no need to > bother. Again, we would only do this if not mountind MS_RDONLY. > > How does that sound? Reasonable :) If it works fine using the new API, we should do it. Szaka |
