At 15:39 11/07/02, Szakacsits Szabolcs wrote:
>On Thu, 11 Jul 2002, Anton Altaparmakov wrote:
> > Yeah, Please adapt your function to accept all 2.x versions, too. (And
> > always treat them in your mind as if they were 3.x, but don't worry too
> > much as the probability of anyone ever running one of our utilities on a
> > system with NTFS 2.x is so tiny it is not worth thinking about!)
>
>Could you please elaborate what you mean? There is NTFS 2.x at all?
Yes. But only developers have it, and I doubt anyone in their sane mind
would be using it... However everything will just work if you assume it is
the same as ntfs 3.0. Ok? [You will encounter a few extra attributes which
you can just ignore]
>Because if we don't know what it is, better to giveup (or user could
>use a "-f" force option) then hoping it will work.
>
> > >int ntfs_version_supported(u8 major, u8 minor)
> >
> > how about
> >
> > BOOL ntfs_is_version_supported(ntfs_volume *vol)
>
>Name is ok (first I thought the same) but please no BOOL. It just
>conflicts with everybody's own BOOL definition, int is better.
We already have BOOL defined so as soon as you include an ntfs header you
would have the conflict. But if you insist leave it int for this function...
gcc-3.x (possibly not early gcc-3.x though) already have their own bool
type in accordance with C99 I believe (or whatever standard it was/will be
that defined/s it, I am not sure), so as soon as that becomes ubiquitously
available we will switch to using that everywhere. I am also thinking of
starting to rename everything now/in the near future and just do some magic
to check if the compiler supports it, and if not typedef our own... But
that is not too high priority. But thinking about it it may be a good idea
to do it before releasing linux-ntfs-2.0.0...
Anton
--
"I've not lost my mind. It's backed up on tape somewhere." - Unknown
--
Anton Altaparmakov <aia21 at cantab.net> (replace at with @)
Linux NTFS Maintainer / IRC: #ntfs on irc.openprojects.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
|