|
From: Anton A. <ai...@ca...> - 2002-07-11 11:45:49
|
At 12:14 11/07/02, Richard Russon wrote: > > aops.c, line 250-257 (from cvs i just checked out) eeek! /me thinks the cvs repository needs to be destroyed!!! >Argh! The cvs repository is obsolete. The latest code is kept >in a BitKeeper repository. We should have made this a bit clearer. > > http://linux-ntfs.bkbits.net:8080/ntfs-tng-2.5 Yes, and there is the development repository as well: http://linux-ntfs.bkbits.net:8080/ntfs-devel Note the two are usually very close together but the devel tree tends to receive things first. The ntfs-tng-2.5 tree only gets things pushed to it when I submit to Linus for inclusion. (He actually pulls from the ntfs-tng-2.5 tree so it has to always correspond to the patches I send to LKML.) >Fortunately the piece of code you're referring to exists in both >versions. aops.c, line 388 (ntfs_readpage). > > > Not that this is a likely occurence or even legal, but to make sure I'm > > sane..... > > > We're making the assumption here that a resident attribute cannot be of > > length > PAGE_CACHE_SIZE, correct? Because it seems to me that this code > > does not take into account any offsets etc, and just returns the beginning > > of the attribute no matter what... am I correct here? > >$Boot tells us how big the MFT records are, implying the value could >vary, but we've only ever seen 1024 byte records. For now the >attributes can't be even close to a page size. Apparently early versions of NTFS used 2048 byte MFT records. But even then, the smallest PAGE_CACHE_SIZE is 4096 bytes and the kernel throughout assumes this to be a fact, i.e. any architecture with PAGE_CACHE_SIZE < 4096 would not actually work with the Linux kernel. So our code assumes the same. Note that in super.c, at mount time, we actually do checks and abort if mft records are bigger (I think, and if we are not we definitely should be!)... Anton -- "I've not lost my mind. It's backed up on tape somewhere." - Unknown -- Anton Altaparmakov <aia21 at cantab.net> (replace at with @) Linux NTFS Maintainer / IRC: #ntfs on irc.openprojects.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/ |
