On Wed, Oct 18, 2023 at 04:41:44AM +0900, Ryusuke Konishi wrote:
> On Tue, Oct 17, 2023 at 5:11 AM Matthew Wilcox (Oracle) wrote:
> >
> > Rename grow_dev_page() to grow_dev_folio() and make it return a bool.
> > Document what that bool means; it's more subtle than it first appears.
> > Also rename the 'failed' label to 'unlock' beacuse it's not exactly
> > 'failed'. It just hasn't succeeded.
>
> This changes the return type of grow_buffers() from "int" to "bool".
> But, it seems that the caller, __getblk_slow(), has not changed the
> type of the variable "ret" that receives its return value:
[...]
>
> So, it looks like the error check immediately after calling
> grow_buffers() will not branch like before.
> Is this okay ? Or, am I missing some other changes?
>
> Also, there is a typo in the changelog: "beacuse" -> "because".
Argh, yes. Andrew, please drop this patch for now. I'll submit
something better next cycle.
|
