linux-ntfs-dev

[Linux-NTFS-Dev] [PATCH] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

[Nikanth K. <kni...@su...>]

Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

When the kernel does partition detection, on certain configurations with
external fibre channel raid systems (e.g. clariion from EMC) the read
would fail. And "ldm_validate_partition_table(): Disk read failed"
messages are printed to the console.

But the failure to read is not a critical error. Now since the message
is flagged as KERN_CRIT, it gets printed even when booting with the
"quiet" kernel parameter. Fix it by using KERN_INFO, as the failure to
read here is not really an error.

Signed-off-by: Nikanth Karthikesan <kni...@su...>
Reported-by : Klaus Hartmann <Kla...@ts...>

---

diff --git a/fs/partitions/ldm.c b/fs/partitions/ldm.c
index 789c625..531f19f 100644
--- a/fs/partitions/ldm.c
+++ b/fs/partitions/ldm.c
@@ -560,7 +560,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state)
 
 	data = read_part_sector(state, 0, &sect);
 	if (!data) {
-		ldm_crit ("Disk read failed.");
+		ldm_info ("Disk read failed.");
 		return false;
 	}
 

[Linux-NTFS-Dev] [PATCH TRIVIAL RESEND] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

[Nikanth K. <kni...@su...>]

Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

When the kernel does partition detection, on certain configurations with
external fibre channel raid systems (e.g. clariion from EMC) the read
would fail. And "ldm_validate_partition_table(): Disk read failed"
messages are printed to the console.

But the failure to read is not a critical error. Now since the message
is flagged as KERN_CRIT, it gets printed even when booting with the
"quiet" kernel parameter. Fix it by using KERN_INFO, as the failure to
read here is not really an error.

Signed-off-by: Nikanth Karthikesan <kni...@su...>
Reported-by : Klaus Hartmann <Kla...@ts...>

---

diff --git a/fs/partitions/ldm.c b/fs/partitions/ldm.c
index b10e354..ea648b9 100644
--- a/fs/partitions/ldm.c
+++ b/fs/partitions/ldm.c
@@ -565,7 +565,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state)
 
 	data = read_part_sector(state, 0, &sect);
 	if (!data) {
-		ldm_crit ("Disk read failed.");
+		ldm_info ("Disk read failed.");
 		return false;
 	}
 

Re: [Linux-NTFS-Dev] [PATCH TRIVIAL RESEND] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

[Anton A. <ai...@ca...>]

Hi,

Patch looks good to me.  Feel free to send it to Linus for inclusion (and CC: LKML).  You can add my signed off line:

Signed-off-by: Anton Altaparmakov <ai...@ca...>

Best regards,

	Anton

On 15 Mar 2011, at 05:55, Nikanth Karthikesan wrote:

> Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"
> 
> When the kernel does partition detection, on certain configurations with
> external fibre channel raid systems (e.g. clariion from EMC) the read
> would fail. And "ldm_validate_partition_table(): Disk read failed"
> messages are printed to the console.
> 
> But the failure to read is not a critical error. Now since the message
> is flagged as KERN_CRIT, it gets printed even when booting with the
> "quiet" kernel parameter. Fix it by using KERN_INFO, as the failure to
> read here is not really an error.
> 
> Signed-off-by: Nikanth Karthikesan <kni...@su...>
> Reported-by : Klaus Hartmann <Kla...@ts...>
> 
> ---
> 
> diff --git a/fs/partitions/ldm.c b/fs/partitions/ldm.c
> index b10e354..ea648b9 100644
> --- a/fs/partitions/ldm.c
> +++ b/fs/partitions/ldm.c
> @@ -565,7 +565,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state)
> 
> 	data = read_part_sector(state, 0, &sect);
> 	if (!data) {
> -		ldm_crit ("Disk read failed.");
> +		ldm_info ("Disk read failed.");
> 		return false;
> 	}

-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/

[Linux-NTFS-Dev] [PATCH] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

[Nikanth K. <kni...@su...>]

From: Nikanth Karthikesan <kni...@su...>
Subject: Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

When the kernel does partition detection, on certain configurations with
external fibre channel raid systems (e.g. clariion from EMC) the read
would fail. And "ldm_validate_partition_table(): Disk read failed"
messages are printed to the console.

But the failure to read is not a critical error. Now since the message
is flagged as KERN_CRIT, it gets printed even when booting with the
"quiet" kernel parameter. Fix it by using KERN_INFO, as the failure to
read here is not really an error.

Signed-off-by: Nikanth Karthikesan <kni...@su...>
Reported-by : Klaus Hartmann <Kla...@ts...>
Signed-off-by: Anton Altaparmakov <ai...@ca...>

---

diff --git a/fs/partitions/ldm.c b/fs/partitions/ldm.c
index b10e354..ea648b9 100644
--- a/fs/partitions/ldm.c
+++ b/fs/partitions/ldm.c
@@ -565,7 +565,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state)
 
 	data = read_part_sector(state, 0, &sect);
 	if (!data) {
-		ldm_crit ("Disk read failed.");
+		ldm_info ("Disk read failed.");
 		return false;
 	}
 

Re: [Linux-NTFS-Dev] [PATCH] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

[Jiri K. <jk...@su...>]

On Thu, 17 Mar 2011, Nikanth Karthikesan wrote:

> From: Nikanth Karthikesan <kni...@su...>
> Subject: Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"
> 
> When the kernel does partition detection, on certain configurations with
> external fibre channel raid systems (e.g. clariion from EMC) the read
> would fail. And "ldm_validate_partition_table(): Disk read failed"
> messages are printed to the console.
> 
> But the failure to read is not a critical error. Now since the message
> is flagged as KERN_CRIT, it gets printed even when booting with the
> "quiet" kernel parameter. Fix it by using KERN_INFO, as the failure to
> read here is not really an error.
> 
> Signed-off-by: Nikanth Karthikesan <kni...@su...>
> Reported-by : Klaus Hartmann <Kla...@ts...>
> Signed-off-by: Anton Altaparmakov <ai...@ca...>
> 
> ---
> 
> diff --git a/fs/partitions/ldm.c b/fs/partitions/ldm.c
> index b10e354..ea648b9 100644
> --- a/fs/partitions/ldm.c
> +++ b/fs/partitions/ldm.c
> @@ -565,7 +565,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state)
>  
>  	data = read_part_sector(state, 0, &sect);
>  	if (!data) {
> -		ldm_crit ("Disk read failed.");
> +		ldm_info ("Disk read failed.");
>  		return false;
>  	}

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.