Re: [Linux-mips-commits]CVS: linux/drivers/net/tuliptulip_core.c,1.8,1.9

[Jun S. <js...@mv...>]

Ralf and/or Jeff (jg...@ma...) will/should take the patch.

Jun

Pete Popov wrote:
> 
> Paul,
> 
> James had applied a small patch I sent him for tulip_core.c. The
> request_irq() really should be done after the tulip_up().  With the
> patch below, we lost the fix.
> 
> Of course, the right thing to do is to send the patch to Alan so we
> don't keep bumping into this problem every time we sync with oss.
> 
> Pete
> 
> On Mon, 2001-11-05 at 16:30, Paul Mundt wrote:
> > Update of /cvsroot/linux-mips/linux/drivers/net/tulip
> > In directory usw-pr-cvs1:/tmp/cvs-serv388/drivers/net/tulip
> >
> > Modified Files:
> >       tulip_core.c
> > Log Message:
> > Sync with OSS 2.4.11.
> >
> >
> >
> > Index: tulip_core.c
> > ===================================================================
> > RCS file: /cvsroot/linux-mips/linux/drivers/net/tulip/tulip_core.c,v
> > retrieving revision 1.8
> > retrieving revision 1.9
> > diff -u -d -r1.8 -r1.9
> > --- tulip_core.c      2001/10/26 20:35:41     1.8
> > +++ tulip_core.c      2001/11/06 00:30:45     1.9
> > @@ -513,6 +513,11 @@
> >       int retval;
> >       MOD_INC_USE_COUNT;
> >
> > +     if ((retval = request_irq(dev->irq, &tulip_interrupt, SA_SHIRQ, dev->name, dev))) {
> > +             MOD_DEC_USE_COUNT;
> > +             return retval;
> > +     }
> > +
> >       tulip_init_ring (dev);
> >
> >       tulip_up (dev);
> > @@ -523,10 +528,6 @@
> >
> >       netif_start_queue (dev);
> >
> > -     if ((retval = request_irq(dev->irq, &tulip_interrupt, SA_SHIRQ, dev->name, dev))) {
> > -             MOD_DEC_USE_COUNT;
> > -             return retval;
> > -     }
> >       return 0;
> >  }
> >
> >
> >
> > _______________________________________________
> > Linux-mips-commits mailing list
> > Lin...@li...
> > https://lists.sourceforge.net/lists/listinfo/linux-mips-commits
> 
> _______________________________________________
> Linux-mips-commits mailing list
> Lin...@li...
> https://lists.sourceforge.net/lists/listinfo/linux-mips-commits