From: Pete P. <pp...@mv...> - 2001-06-27 17:09:26
|
James Simmons wrote: >>I just updated most of the Alchemy Au1000 files. >> > >Great work. > >>which modifies arch/mips/kernel/head.S (inside ifdefs) to deal >>with 36 bit physical addresses of that cpu only. I would like to get >>some comments on whether this can be accepted in an external tree like >>this one. >> > >Hum. Shouldn't this be CPU specific? > The code that's inside ifdefs is cpu specific. But right now there's only one head.S file so there's no other place to put it. If I create a new head.S (au1000_head.S, for example), then I would have to modify arch/mips/Makefile. Another option is to put in a new except_vec0_xxxx routine, which is the routine I've modified. There's already a few of those for different cpus, so there's a precedent there. Hmm, I think that's what I should do. >Regarding the pcmcia, how about if I bring in only the files I need for >this board (which unfortunately is most of the files under >drivers/pcmcia)? > > >Please only the ones you modified. Just drop the tree over Linus tree and >your set to go. > Right, I think I was still confused about the drop-in tree when I sent that email. I'll do it next week. Pete |