From: Pete P. <pp...@mv...> - 2001-06-26 17:01:04
|
James Simmons wrote: >>In other words, it's OK to commit new drivers to, let's say, drivers/net >>in the linux-mips tree? That would be fine -- I thought that by the >>drop-in approach this wasn't desirable. >> > >Yes. With the drop down approach we just have to keep the Config.in and >Makefile files in sync. > >>The pcmcia client drivers use insl/outsl instructions, >>eventhough pcmcia is 16 bit. The mips insl/outsl macros do not work on >>my board because it only does 16 bit pcmcia accesses. So I had to >>"ifdef" the io.h file to redefine the insl/outsl macros to use 16 bit >>accesses. The patch is small, but ugly because it modifies a mips >>global file with a board-specific ifdef. I don't know if Ralf would take >>that patch. What do you do in this case? >> > >I doubt he would like it. Is this card used for other platforms as well? > No, it's mips only, and the pcmcia controller is part of the SOC. I don't want to modify pcmcia client drivers, because that's even worse. Keeping patches around is also a pita. Pete |