Update of /cvsroot/linux-mips/linux/arch/mips/kernel
In directory usw-pr-cvs1:/tmp/cvs-serv5854/arch/mips/kernel
Modified Files:
irq.c
Log Message:
Require dev_id for shared irqs.
Index: irq.c
===================================================================
RCS file: /cvsroot/linux-mips/linux/arch/mips/kernel/irq.c,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -d -r1.5 -r1.6
--- irq.c 2001/10/12 17:33:56 1.5
+++ irq.c 2001/10/28 21:09:09 1.6
@@ -350,18 +350,12 @@
int retval;
struct irqaction * action;
-#if 1
/*
- * Sanity-check: shared interrupts should REALLY pass in
- * a real dev-ID, otherwise we'll have trouble later trying
- * to figure out which interrupt is which (messes up the
- * interrupt freeing logic etc).
+ * Shared interrupts require a dev_id, otherwise we can't
+ * later figure out which interrupt to free.
*/
- if (irqflags & SA_SHIRQ) {
- if (!dev_id)
- printk("Bad boy: %s (at 0x%x) called us without a dev_id!\n", devname, (&irq)[-1]);
- }
-#endif
+ if ((irqflags & SA_SHIRQ) && !dev_id)
+ return -EINVAL;
if (irq >= NR_IRQS)
return -EINVAL;
|