Re: [linux-iscsi-devel] [PATCH] make can queue adjustable

[Mike C. <mic...@cs...>]

Mike Christie wrote:
> Dave Wysochanski wrote:
> 
>>
>> Seems reasonable, with one caveat.
>> Do we really need  S_IWUSR permission on these module parameters?
>>
>> Seems like it might open the door to strange scenarios, like someone 
>> loading
>> the module with no special can_queue value, then changing it via proc. In
>> this case, we don't really know what each host can_queue value is because
>> there's no way to dump the value for each host, right?
> 
> 
> read it via the same file?
> 
>>
>> Maybe there's a scenario where we'd want to give the flexibility of 
>> changing
>> this on the fly.  If not, I'd say just make it read only and force 
>> people to
>> change it only at module load time.  Same goes for the other param's 
>> (though
>> I know your patch wasn't really against those).
>>
> 
> Having those values settable in the first place as just module vars is 
> dangerous and most pepole out there should not be touching them it is 
> there for testing and debugging on the fly and just in case they are too 
> high we can adjust them without a patch or update.
> 

Actually I like it better to make them just module syfsfiles, so all the 
configuration stuff is under sys at almost the same place. I do not know 
or care. Wasn't this someone else's bug? :)