Re: [linux-iscsi-devel] 4/18/2005 TODO list for 4-0 branch 2.6.9 kernel stabilization effort

[AJ L. <al...@re...>]

Bah - today is not my day - hit undo one too many times in the editor before I
generated that patch.  Here's a correct one.

On Tue, Apr 19, 2005 at 01:26:30PM -0500, AJ Lewis wrote:
> On Mon, Apr 18, 2005 at 06:27:56PM -0400, David Wysochanski wrote:
> > Ok, I see what you mean now.
> > 
> > In RHEL3 U4, this "ANSI SCSI revision" field prints a '4' for
> > all Netapp targets, which is what the lower 3 bits of the 3rd
> > byte is.  In 2.6 kernels, scsi_level is not exactly what
> > is returned in the inquiry data:
> > 
> > scsi_scan.c:scsi_probe_lun()
> >         /*
> >          * The scanning code needs to know the scsi_level, even if no
> >          * device is attached at LUN 0 (SCSI_SCAN_TARGET_PRESENT) so
> >          * non-zero LUNs can be scanned.
> >          */
> >         sdev->scsi_level = inq_result[2] & 0x07;
> >         if (sdev->scsi_level >= 2 ||
> >             (sdev->scsi_level == 1 && (inq_result[3] & 0x0f) == 1))
> >                 sdev->scsi_level++;
> > 
> > 
> > include/scsi/scsi.h:
> > /*
> >  *  struct scsi_device::scsi_level values. For SCSI devices other than those
> >  *  prior to SCSI-2 (i.e. over 12 years old) this value is (resp[2] + 1)
> >  *  where "resp" is a byte array of the response to an INQUIRY. The 
> >  scsi_level
> >  *  variable is visible to the user via sysfs.
> >  */
> > 
> > #define SCSI_UNKNOWN    0
> > #define SCSI_1          1
> > #define SCSI_1_CCS      2
> > #define SCSI_2          3
> > #define SCSI_3          4        /* SPC */
> > #define SCSI_SPC_2      5
> > #define SCSI_SPC_3      6
>  
> Attached incremental patch against my previous iscsi-ls patch to further
> improve output compatibility with the 3.6 iscsi-ls tool.  Also adjusted #!
> line to call bash directly, since (AFAIK) we're calling bash specific
> functionality in the script.
>  
> -- 
> AJ Lewis                                   Voice:  612-638-0500
> Red Hat Inc.                               E-Mail: al...@re...
> 720 Washington Ave. SE, Suite 200
> Minneapolis, MN 55414
>    
> Current GPG fingerprint = D9F8 EDCE 4242 855F A03D  9B63 F50C 54A8 578C 8715
> Grab the key at: http://people.redhat.com/alewis/gpg.html or one of the
> many keyservers out there...
> 



-- 
AJ Lewis                                   Voice:  612-638-0500
Red Hat Inc.                               E-Mail: al...@re...
720 Washington Ave. SE, Suite 200
Minneapolis, MN 55414
   
Current GPG fingerprint = D9F8 EDCE 4242 855F A03D  9B63 F50C 54A8 578C 8715
Grab the key at: http://people.redhat.com/alewis/gpg.html or one of the
many keyservers out there...