Menu
▾
▴
[linux-iscsi-devel] [ linux-iscsi-Bugs-1180956 ] iscsi_transport attributes don't reflect meaningful values
|
From: SourceForge.net <no...@so...> - 2005-04-12 18:17:28
|
Bugs item #1180956, was opened at 2005-04-11 14:46 Message generated for change (Settings changed) made by wysochanski You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=387023&aid=1180956&group_id=26396 Category: iscsi-drvr Group: 4.0.2 Status: Open Resolution: None Priority: 5 Submitted By: Dave Wysochanski (wysochanski) >Assigned to: Dave Wysochanski (wysochanski) Summary: iscsi_transport attributes don't reflect meaningful values Initial Comment: Looks like we have a bug where we're not updating the attributes in iscsi_transport class after login. I haven't really looked at the code that much but things like max_recv_data_segment_len (initiator's declared value in login sequence) is always 131072 and max_burst_len is always 65536 (both wrong in my setup). My target shows the correct negotiated values for these keys and a login trace proves the intiator is wrong for displaying these values. Cursory look at the code seems to indicate we're only updating these attributes from iscsi_update_portal_info(), which is only called before login has completed (see iscsi_ioctl_establish_session() calling iscsi_update_session() before iscsi_create_host()). Found this on the the latest 4-0 branch (stable 2.6.9 effort) but it applies to 4.0.2 tarball as well so just filed it against that group. ---------------------------------------------------------------------- Comment By: Dave Wysochanski (wysochanski) Date: 2005-04-11 15:07 Message: Logged In: YES user_id=752546 The values in the transport class should really be the negotiated values. Otherwise, they're really not meaningful, and the resulting output from "iscsi-ls -c" will be different from before and not mean anything to most users. I don't claim to know what the best way to do that in the code. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2005-04-11 14:55 Message: Logged In: NO the portal values are user requested values. session duplciates are the values we negotiated (the login api passes around a session struct and sets them). this is why iscsi_update_portal_info() is called only in iscsi_update_session. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=387023&aid=1180956&group_id=26396 |
