Re: [linux-iscsi-devel] [ linux-iscsi-Bugs-1180956 ] iscsi_transport attributes don't reflect meaningful values

[David W. <da...@ne...>]

Mike Christie wrote:
> David Wysochanski wrote:
>  > Mike Christie wrote:
>  >
>  >> Mike Christie wrote:
>  >>  > SourceForge.net wrote:
>  >>  >
>  >>  >> Bugs item #1180956, was opened at 2005-04-11 14:46
>  >>  >> Message generated for change (Comment added) made by wysochanski
>  >>  >> You can respond by visiting:
>  >>  >>
>  >> 
> https://sourceforge.net/tracker/?func=detail&atid=387023&aid=1180956&group_id=26396 
> <https://sourceforge.net/tracker/?func=detail&atid=387023&aid=1180956&group_id=26396> 
> 
>  >> 
> <https://sourceforge.net/tracker/?func=detail&atid=387023&aid=1180956&group_id=26396 
> <https://sourceforge.net/tracker/?func=detail&atid=387023&aid=1180956&group_id=26396>> 
> 
>  >>
>  >>  >>
>  >>  >>
>  >>  >> Category: iscsi-drvr
>  >>  >> Group: 4.0.2
>  >>  >> Status: Open
>  >>  >> Resolution: None
>  >>  >> Priority: 5
>  >>  >> Submitted By: Dave Wysochanski (wysochanski)
>  >>  >> Assigned to: Manish Kumar Bhojasia (bhojas)
>  >>  >> Summary: iscsi_transport attributes don't reflect meaningful values
>  >>  >>
>  >>  >> Initial Comment:
>  >>  >> Looks like we have a bug where we're not updating the
>  >>  >> attributes in iscsi_transport class after login.  I
>  >>  >> haven't really looked at the code that much but things
>  >>  >> like max_recv_data_segment_len (initiator's declared
>  >>  >> value in login sequence) is always 131072 and
>  >>  >> max_burst_len is always 65536 (both wrong in my setup).
>  >>  >>  My target shows the correct negotiated values for
>  >>  >> these keys and a login trace proves the intiator is
>  >>  >> wrong for displaying these values.
>  >>  >>
>  >>  >> Cursory look at the code seems to indicate we're only
>  >>  >> updating these attributes from
>  >>  >> iscsi_update_portal_info(), which is only called before
>  >>  >> login has completed (see
>  >>  >> iscsi_ioctl_establish_session() calling
>  >>  >> iscsi_update_session() before iscsi_create_host()).
>  >>  >>
>  >>  >> Found this on the the latest 4-0 branch (stable 2.6.9
>  >>  >> effort) but it applies to 4.0.2 tarball as well so just
>  >>  >> filed it against that group.
>  >>  >>
>  >>  >>
>  >>  >>
>  >>  >>
>  >> ----------------------------------------------------------------------
>  >>  >>
>  >>  >>
>  >>  >>> Comment By: Dave Wysochanski (wysochanski)
>  >>  >>
>  >>  >>
>  >>  >> Date: 2005-04-11 15:07
>  >>  >>
>  >>  >> Message:
>  >>  >> Logged In: YES user_id=752546
>  >>  >>
>  >>  >> The values in the transport class should really be the
>  >>  >> negotiated values.
>  >>  >
>  >>  >
>  >>  >
>  >>  > As it is coded they are supposed to be. They reference the session
>  >>  > fields not the portal ones.
>  >>  >
>  >>
>  >> Actually don't we want both if we want backward compat with the old
>  >> tool? It used to dump both values.
>  >>
>  > "iscsi-ls -c" has only ever dumped negotiated login session
>  > values as far as I know.
>  >
> 
> You're right. It copied the whole portal for the fun of it I guess.
> 
> Do you want this bug? I am pretty sure my values are changing. I will double
> check in a minute though.
> 

Yes, I can take it unless you have a quick fix.