Re: [linux-iscsi-devel] [PATCH] race fixes

[Mike C. <mi...@us...>]

Smitha Narayanaswamy (smithan) wrote:
> The patch fixes two race conditions that were detected while checking
> SESSION_REPLACEMENT_TIMEDOUT and SESSION_ESTABLISHED.

we actually talked about this one, remember? I added the comment you 
removed in the patch to remind us. :)

Patch looks ok for the distro version using the replacement timeout. If 
we did not combine with open-iscsi the block/unblock code would have 
replaced this so it is not needed in main

that reminds me for the distro versions, you are still going to modify 
replcement timeout code for shutdown right? I think for shutdown we 
should have two modes: a forced mode that disregards if FS's are mounted 
and writes are in progress, and a safe mode which just waits for 
whatever. Is this what you were planning on doing or were you going to 
change shutdown to only do forced shutdown?



> 
> Thanks,
> Smitha
> 
>