Re: [linux-iscsi-devel] [PATCH]op_params whose result function is OR

[Dave W. <da...@ne...>]

Smitha Narayanaswamy (smithan) wrote:

> Here is an excerpt from the iSCSI rfc:
> 12.10.  InitialR2T
>    Use: LO
>    Senders: Initiator and Target
>    Scope: SW
>    Irrelevant when: SessionType=Discovery
>
>    InitialR2T=<boolean-value>
>
>    Examples:
>
>       I->InitialR2T=No
>       T->InitialR2T=No
>
>    Default is Yes.
>    Result function is OR.
>
> The default action is that R2T is required, unless both the initiator
>    and the target send this key-pair attribute specifying
> InitialR2T=No.
>    Only the first outgoing data burst (immediate data and/or separate
>    PDUs) can be sent unsolicited (i.e., not requiring an explicit
> R2T).
>
> The original code was a protocol violation.
>
How is that?
The initiator sends "InitialR2T=No".
If it gets back "Yes", then the resulting OR
is "Yes", or a '1' value.  Otherwise, it's
"No" or a '0' value. 

> > -----Original Message-----
> > From: Dave Wysochanski [mailto:da...@ne...]
> > Sent: Thursday, March 17, 2005 10:48 AM
> > To: sm...@ci...
> > Cc: linux-iscsi-devel
> > Subject: Re: [linux-iscsi-devel] [PATCH]op_params whose
> > result function is OR
> >
> > Keep in mind for these keys, the conservative result
> > is "Yes", or a '1' value.  Thus, the logic checks for
> > "Yes", and sets a '1' value if it gets this from the
> > target.  Otherwise, it sets a '0' value, the more
> > advanced/optional behavior that not every target
> > supports.
> >
> > I think the original code is correct.  Are you
> > sure you're seeing a bug?
> >
> > Smitha Narayanaswamy (smithan) wrote:
> >
> > > For Operational parameters whose result function is OR on
> > negotiation
> > > (InitialR2T, DataPDUInOrder, DataSequenceInOrder), there has been
> a
> > > protocol violation. The patch fixes it.
> > > Please review the patch.
> > >
> > > Thanks,
> > > Smitha
> > >
> > >
> > >-------------------------------------------------------------
> > -----------
> > >
> > >
> > >
> > >-------------------------------------------------------
> > >SF email is sponsored by - The IT Product Guide
> > >Read honest & candid reviews on hundreds of IT Products from
> > real users.
> > >Discover which products truly live up to the hype. Start reading
> now.
> > >http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click 
> <http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click>
> > >_______________________________________________
> > >linux-iscsi-devel mailing list
> > >lin...@li...
> > >https://lists.sourceforge.net/lists/listinfo/linux-iscsi-devel
> > >
> > >
> >
>