Re: [Linux-ima-devel] [PATCH 5/7] evmctl: Use macros for signature versions

[Vivek G. <vg...@re...>]

On Mon, Jul 15, 2013 at 06:56:17PM +0300, Dmitry Kasatkin wrote:
> On Fri, Jul 12, 2013 at 9:52 PM, Vivek Goyal <vg...@re...> wrote:
> > Using macros for fixed values looks cleaner. Also I am planning to use
> > version field in more places in next patch. So use macros intead of
> > numbers like 1 and 2.
> >
> > Signed-off-by: Vivek Goyal <vg...@re...>
> > ---
> >  src/evmctl.c |    7 +++++--
> >  1 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/evmctl.c b/src/evmctl.c
> > index 08b2b81..03a81ae 100644
> > --- a/src/evmctl.c
> > +++ b/src/evmctl.c
> > @@ -90,6 +90,9 @@
> >  #define FS_IOC32_GETFLAGS      _IOR('f', 1, int)
> >  #define FS_IOC32_SETFLAGS      _IOW('f', 2, int)
> >
> > +#define DIGSIG_VERSION_1       1
> > +#define DIGSIG_VERSION_2       2
> > +
> 
> Why not enums?

enums are fine too. Didn't think about that.

Thanks
Vivek