IMA/EVM Utils Merge Request #3: Allow Disablement of evmctl and Doc Generation (rejected)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Purushottam Kulkarni wants to merge 1 commit from /u/puruk/linux-ima/ to master, 2022-01-18
Hi ima-evm-utils Maintainers,
My name is Puru Kulkarni, and I currently work at Juniper Networks, Inc.
We are currently working on writing rust-bindings for libimaevm, and creating
a rust-based utility similar to evmctl.
For this purpose we need these changes merged into ima-evm-utils.
We would greatly appreciate it if you could consider merging these changes.
Please consider the attached patch for a merge to ima-evm-utils master.
Thanks,
Puru
| Commit | Date | |
|---|---|---|
|
[017982]
(HEAD, master)
by
Puru Kulkarni
Allow Disablement of evmctl and Doc Generation Currently, the ima-evm-utils builds the evmctl binary as well We need the ability to disable the generation of the evmctl binary * We wish to write rust-bindings for libimaevm This change: * Adds automake logic to add two flags: 1. --disable-evmctl - To disable the generation of evmctl The usage of these flags is during the configuration of the build ./configure --disable-evmctl To just disable the generation of documentation: ./configure --disable-evmctl-doc To disable both the generation of evmctl binary and docs: ./configure \ Signed-off-by: Puru Kulkarni <puruk@...> |
2022-01-05 21:49:53 | Tree |
Responded on the ima-evm-utils mailing list with suggestions:
- display new variable status in configure.ac
- questioned the need for --disable-evmctl-doc
- no need for if/then/else in src/Makefile.am