Re: [Linux-igd-devel] FW: Linux IGD was ported to NetBSD.

[Nektarios K. P. <npa...@in...>]

I didn't look very thoroughly through the code, but see my comments=20
inline...

Juho V=E4h=E4-Herttua wrote:
> I read through this and from what I can see it has at least four =20
> patches combined together.
>=20
> First of all it disables the iptables command parsing totally in non-=20
> linux systems. Another thing is that it adds checks for =20
> UPNP_HAVE_DEBUG and moves some of the code inside that, apparently =20
> libupnp log level and other logging stuff. (don't know the reason for =20
> this, maybe linux-igd doesn't work on libupnp compiled without =20
> debug?)
AFAIK linux-igd is working fine with libupnp compiled without debug.=20
AFAICT the purpose of the patch is just to make linux-igd take=20
advantage/configure the debugging functionalities of the libupnp if=20
available.

> Third thing is that it refactors some linux-igd code (mainly =20
> socket code) to linux.c file and adds netbsd.c file that does the =20
> same with some modifications. And last but not least it adds the =20
> ioctl stuff that is used to control netbsd filters.
>=20
> Then there's the libupnp patch he clearly couldn't get upstream at =20
> libupnp so he sent it to us, it's a big piece in itself and seems to =20
> concentrate in replacing some functions not found on netbsd.
libupnp development is continued at the pupnp project:
http://sourceforge.net/projects/pupnp
http://www.libupnp.org
I'm working on that project but I have zero experience with netbsd.=20
pupnp is really positive about supporting new platforms but we're really=20
short on resources. BTW, is it ok if I post the patch there?
>=20
> Personally I think this patch should be divided into smaller pieces =20
> and I'm not even sure all of it should be applied. The #define =20
> __linux__ for one is very ugly, it would be much better practice to =20
> add new defines for the problematic pieces or rewrite them to work on =20
> all systems, it is possible. But who knows japanese enough to reply =20
> to this guy? He clearly can't speak english... :p
Perhaps we can use machine translation too :p

>=20
>=20
>=20
> Juho
>=20
>=20
> On 7.9.2006, at 18:36, ew...@er... wrote:
>> -----Original Message-----
>> From: Kouji Suzuki [mailto:k...@ke...]
>> Sent: Thursday, September 07, 2006 11:00 AM
>> To: di...@gu...
>> Cc: ew...@er...
>> Subject: Linux IGD was ported to NetBSD.
>>
>> Dear Mr. Glover.
>>
>> # Because the machine translation is used, # the sentence might be not
>> correct.
>>
>> I succeeded in the movement of LinuxIGD-0.95 on NetBSD-3.0.
>> Please merge this patch with LinuxIGD.
>>
>> In NetBSD, NAT is controlled by using PF.
>> PF uses the pfctl command usually.
>> However, this patch is controlled directly by using ioctl.
>> Perhaps, it corresponds to iptc in linux.
>>
>> The thing of the separation of the fire wall function was being =20
>> written on
>> the ToDo page.
>> This patch considers the thing a little.
>>
>> The code shown in linux was described in linux.[ch], the code shown in
>> NetBSD was described in netbsd.[ch], and the code shown in PF made it
>> describe in pf.[ch].
>> However, it is still imperfect.
>>
>> To ensure it, it thinks the code that uses the iptables command to =20
>> be should
>> separate.
>> However, it decided to avoid it in the fear of the patch's growing.
>>
>> Moreover, because the development of libupnp-1.3.1 stops, the patch =20
>> to the
>> library is put in ./etc.
>> This patch assumes the person who thinks that it uses it with =20
>> NetBSD applies
>> by himself/herself.
>> Therefore, please append it as it is.
>>
>>
>> Best regards.
>>
>> ----------------------
>> Kouji Suzuki
>> mailto:k...@ke...
>> # It will be automatically discarded if the attached file of # =20
>> executable
>> files or "HTML mail" is transmitted to this mail address.
>> <linuxigd-0.95-nb.diff.bz2>
>> ----------------------------------------------------------------------=
=20
>> ---
>> Using Tomcat but need to do more? Need to support web services, =20
>> security?
>> Get stuff done quickly with pre-integrated technology to make your =20
>> job easier
>> Download IBM WebSphere Application Server v.1.0.1 based on Apache =20
>> Geronimo
>> http://sel.as-us.falkag.net/sel?=20
>> cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D121642______________________=
________=20
>> _________________
>> Linux-igd-devel mailing list
>> Lin...@li...
>> https://lists.sourceforge.net/lists/listinfo/linux-igd-devel
>=20
>=20
> -----------------------------------------------------------------------=
--
> Using Tomcat but need to do more? Need to support web services, securit=
y?
> Get stuff done quickly with pre-integrated technology to make your job =
easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geron=
imo
> http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=
=3D121642
> _______________________________________________
> Linux-igd-devel mailing list
> Lin...@li...
> https://lists.sourceforge.net/lists/listinfo/linux-igd-devel
>=20

--=20
______________________________________________________________
Nektarios K. Papadopoulos
Senior Engineer
Software Engineering Group
inAccess Networks
95A Pentelis Avenue.    Tel    : +30-210-6837640
152 34 Halandri Athens  Fax    : +30-210-6899504
______________________________________________________________