Re: [Linux-igd-devel] FW: Linux IGD was ported to NetBSD.

[<juh...@tk...>]

I read through this and from what I can see it has at least four  
patches combined together.

First of all it disables the iptables command parsing totally in non- 
linux systems. Another thing is that it adds checks for  
UPNP_HAVE_DEBUG and moves some of the code inside that, apparently  
libupnp log level and other logging stuff. (don't know the reason for  
this, maybe linux-igd doesn't work on libupnp compiled without  
debug?) Third thing is that it refactors some linux-igd code (mainly  
socket code) to linux.c file and adds netbsd.c file that does the  
same with some modifications. And last but not least it adds the  
ioctl stuff that is used to control netbsd filters.

Then there's the libupnp patch he clearly couldn't get upstream at  
libupnp so he sent it to us, it's a big piece in itself and seems to  
concentrate in replacing some functions not found on netbsd.

Personally I think this patch should be divided into smaller pieces  
and I'm not even sure all of it should be applied. The #define  
__linux__ for one is very ugly, it would be much better practice to  
add new defines for the problematic pieces or rewrite them to work on  
all systems, it is possible. But who knows japanese enough to reply  
to this guy? He clearly can't speak english... :p



Juho


On 7.9.2006, at 18:36, ew...@er... wrote:
> -----Original Message-----
> From: Kouji Suzuki [mailto:k...@ke...]
> Sent: Thursday, September 07, 2006 11:00 AM
> To: di...@gu...
> Cc: ew...@er...
> Subject: Linux IGD was ported to NetBSD.
>
> Dear Mr. Glover.
>
> # Because the machine translation is used, # the sentence might be not
> correct.
>
> I succeeded in the movement of LinuxIGD-0.95 on NetBSD-3.0.
> Please merge this patch with LinuxIGD.
>
> In NetBSD, NAT is controlled by using PF.
> PF uses the pfctl command usually.
> However, this patch is controlled directly by using ioctl.
> Perhaps, it corresponds to iptc in linux.
>
> The thing of the separation of the fire wall function was being  
> written on
> the ToDo page.
> This patch considers the thing a little.
>
> The code shown in linux was described in linux.[ch], the code shown in
> NetBSD was described in netbsd.[ch], and the code shown in PF made it
> describe in pf.[ch].
> However, it is still imperfect.
>
> To ensure it, it thinks the code that uses the iptables command to  
> be should
> separate.
> However, it decided to avoid it in the fear of the patch's growing.
>
> Moreover, because the development of libupnp-1.3.1 stops, the patch  
> to the
> library is put in ./etc.
> This patch assumes the person who thinks that it uses it with  
> NetBSD applies
> by himself/herself.
> Therefore, please append it as it is.
>
>
> Best regards.
>
> ----------------------
> Kouji Suzuki
> mailto:k...@ke...
> # It will be automatically discarded if the attached file of #  
> executable
> files or "HTML mail" is transmitted to this mail address.
> <linuxigd-0.95-nb.diff.bz2>
> ---------------------------------------------------------------------- 
> ---
> Using Tomcat but need to do more? Need to support web services,  
> security?
> Get stuff done quickly with pre-integrated technology to make your  
> job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache  
> Geronimo
> http://sel.as-us.falkag.net/sel? 
> cmd=lnk&kid=120709&bid=263057&dat=121642______________________________ 
> _________________
> Linux-igd-devel mailing list
> Lin...@li...
> https://lists.sourceforge.net/lists/listinfo/linux-igd-devel