Re: [Linux-igd-devel] About linux igd

[Nektarios K. P. <npa...@in...>]

Hi Jimmy,

glad you found my patch useful. BTW, did you merge it in CVS-HEAD?

Regarding your new comment, you are correct this is a bug in linux-igd.

However, I'm afraid that modifying GetFirstDocumentItem will not help you mutch.
 Looking at the code, it seems that the problem is deeper in pupnp libixml,
implementation and that ixmlDocument_getElementsByTagName does not return the
node at all.

Actually, I have the impression that I've seen such reports about ixml before,
but I can't find the reference.

Nevertheless, as a work around you can move the check for 'desc' out of the 'if'
at the beginning of AddPortMapping and modify pmlist.c accordingly. See attached
patches agains CVS-HEAD.

Meanwhile, I'll investigate the status of ixmlDocument_getElementsByTagName and
if I can't provide a fix will at least make a proper bug report in pupnp ;-)

cheers,
nek

PS. I CC'd the list again since I believe this is of interest to all. BTW, if
you do post on the list you don't need to CC' me, since I'm subscribed.

jimmy wrote:
> Hi nek:
>    Thanks for previuos "UDN" patch you have done, it works  : )
>    Now I found another issue.
> 
>    I am using Intel too IntelToolsForUPnPTechnology_v2.NET 1.0_2777 to 
> test,
> When I invoke addportmapping, igd return 500 Internal Server Error,
> Below is the ethereal log, look the XML tag
> 
> <NewPortMappingDescription />
> 
> It only has closing tag without opening tag and any content. And igd 
> takes it as incorrect (in gatedevice.c, function AddPortMapping() )
> but in UPnP-DeviceArchitecture-v1.0.pdf, it say it's valid,
> 
> "If an action has no “in” arguments, it is valid to combine the opening 
> and closing XML tags (e.g., “<actionname/>” instead of
> “<actionname></actionname>”)."
> 
> 
>    Thus, I am trying to modified and do more test.I think it maybe need 
> to modify function GetFirstDocumentItem .
> 
>    Hope this info is helpful  for you
> 
> Regards
> 
> Jimmy
> ***************************************************************
> <?xml version="1.0" encoding="utf-8"?>
> 
> <s:Envelope s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/" 
> xmlns:s="http://schemas.xmlsoap.org/soap/envelope/">
> 
>   <s:Body>
> 
>      <u:AddPortMapping 
> xmlns:u="urn:schemas-upnp-org:service:WANIPConnection:1">
> 
>         <NewRemoteHost>168.95.1.1</NewRemoteHost>
> 
>         <NewExternalPort>3000</NewExternalPort>
> 
>         <NewProtocol>TCP</NewProtocol>
> 
>         <NewInternalPort>3000</NewInternalPort>
> 
>         <NewInternalClient>192.168.0.100</NewInternalClient>
> 
>         <NewEnabled>1</NewEnabled>
> 
>         <NewPortMappingDescription />
> 
>         <NewLeaseDuration>0</NewLeaseDuration>
> 
>      </u:AddPortMapping>
> 
>   </s:Body>
> 

-- 
______________________________________________________________
Nektarios K. Papadopoulos
Senior Engineer
Home Automation Group
inAccess Networks
______________________________________________________________