Re: [Linux-fbdev-devel] fb_imageblit semantic

[Geert U. <ge...@li...>]

On 17 Mar 2003, Antonino Daplas wrote:
> As Geert said, it's not just trivial, but logical to split fb_imageblit
> into two.

So, are we gonna split it? This will also make hardware acceleration support
more clean. E.g. most sbus drivers do color expansion in hardware, and fall
back to cfb_imageblit() for the logo.

> > OK, so rule is that if depth=0, input is 1bpp with palette in bgcol/fgcol,
> > while if depth != 0, then palette is in info->pseudo_palette ?
> 
> Yes.  You can also say that if image->depth != var->bits_per_pixel, do
> color expansion or reduction, whatever the case may be.

Hmmm... Note that image->depth can be larger than 8, while the image data is
still 8-bit. This is an inconsistency.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds