Re: [Linux-fbdev-devel] fb_imageblit semantic

[Petr V. <VAN...@vc...>]

On 14 Mar 03 at 10:22, Geert Uytterhoeven wrote:
> On Thu, 13 Mar 2003, Petr Vandrovec wrote:
> > Why do you pass image.depth == 16 (or 24 or 32) to fb_imageblit
> > when logo image is in reality always 8bpp, as quick look at 
> > cfb_imageblit revealed?
> 
> Should indeed be 8.
> 
> > Should I just assume that image.depth == 1 means that data are
> > 1bpp with fgcol/bgcol valid, and all other depths mean 8bpp
> > input?
> 
> This was changed from 1 to 0 in James' latest tree.

WTF? Color depth 0 means that whole picture is single-color, and
imageblit degenerates to rectfill in such case. Please, either
use 'depth' as source image color depth, or do not name it depth.
                                                Petr Vandrovec