|
From: Antonino D. <ad...@po...> - 2003-03-06 01:17:00
|
On Thu, 2003-03-06 at 03:43, James Simmons wrote: > > > > I think you should only accept modes where the difference is a fraction > > > of a character width or height. A difference more than that and > > > clear_margins() will not work correctly. > > > > > > > I apologize for my stupidity, fbdev does not know the font dimensions. > > I guess, we'll just need to really bring back fbset resizing. > > I disagree that fbset is the solution to all things. The problem is > fbcon_resize is severally broken. The reality is that there are fixed mode fbcon_resize() is not that broken, it's only trying to do what it's supposed to do. It is indeed limited because it is trying to outguess the low-level drivers on the best resolution for a window size. However, the brokenness is really on the driver side. They are unable to change the video mode unless they are supplied with the correct timing parameters where in fact they actually have the best knowledge on how to calculate them. So the question: Do we let fbcon spoonfeed the timings to fbdev, or do we let the drivers calculate it for themselves? I go for the latter, as fbcon really should not have any business with hardware. > resolutions (i.e. LCD displays). So fbcon has to adpat to this. What we > shoudl do is set the console mode fit slightly smaller than that the > actually resolution. The reason being is partially drawn fonts at the Yes, Geert's accel_clear_margin fix should help that. Tony |