[Linux-fbdev-devel] dead code in fbcon

[Geert U. <ge...@li...>]

fbcon_changevar() contains some code (copy-and-pasted from
fbcon_set_display()?) which is never used because save is never set to
non-NULL.

--- linux-2.5.59/drivers/video/console/fbcon.c	Fri Jan 17 12:09:27 2003
+++ linux-geert-2.5.59/fbcon.c	Mon Feb 10 10:19:58 2003
@@ -766,7 +766,6 @@
 		struct vc_data *vc = p->conp;
 		int nr_rows, nr_cols;
 		int old_rows, old_cols;
-		unsigned short *save = NULL, *q;
 		int i, charcnt = 256;
 		struct font_desc *font;
 
@@ -846,15 +845,6 @@
 		 	vt_cons[vc->vc_num]->vc_mode == KD_TEXT) {
 			accel_clear_margins(vc, p, 0);
 			update_screen(con);
-		}
-		if (save) {
-			q = (unsigned short *) (vc->vc_origin +
-						vc->vc_size_row *
-						old_rows);
-			scr_memcpyw(q, save, logo_lines * nr_cols * 2);
-			vc->vc_y += logo_lines;
-			vc->vc_pos += logo_lines * vc->vc_size_row;
-			kfree(save);
 		}
 
 		if (con == fg_console && softback_buf) {

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds