Re: [Linux-fbdev-devel] rivafb "Badness" using fbdev.diff.gz and 2.5.5[45]

[James S. <jsi...@in...>]

> >  after clearing green screen using fbset, text colours are wrong
> ...unfortunately, upon exit, the driver restores only the partly
> initialized state, thus the vga console text colors are wrong. 

We should move the riva_load_state(par->initial_state) in riavfb_remove to 
rivafb_release. 
 
> >  rmmod fbcon locks up machine, no ALT-SYSRQ effective
> This is wishful thinking :-), as fbcon cannot be unloaded (yet). 

It works if you have more than one type of VT console system. I use MDA 
console with FB console. This way I can add and remove fbcon.o at will and 
test it in detail.

> Calling riva_common_setup() calls RivaGetConfig() which modifies the
> hardware.  Since we only need fix->smem_len and the bandwidth from
> RivaGetConfig(), I isolated them into riva_get_memlen() and
> riva_get_maxdclk().  RivaGetConfig will be called from rivafb_open()
> anyway.

I applied part of the patch. I like to avoid changing nv_driver to much 
because it is based on the X windows driver. Easier to keep them sync. 
What we could do is move the following 

riva_common_setup(par);
..

par->dclk_max = par->riva.MaxVClock..

from rivafb_probe to riavfb_open. Can you give tht a try and tell me if it 
works.