Re: [Linux-fbdev-devel] rivafb "Badness" using fbdev.diff.gz and 2.5.5[45]

[Jak <rf...@ei...>]

Tony,
=09thanks for your patches, they have fixed most of the problems I had.
>
> Try running stty to fix your display.
>
I can't convince stty to do anything useful for me :
=09do I need a specific/patched version ?
=09do I need to specify anything except rows cols values ?
=09how would I change the colour depth ?
=09I have 7 different lines in /etc/fb.modes related to 1024x768@8bpp,
how can I tell stty that I want to use the equivalent of the timing value=
s of
any particular one of these 7 modes ( assuming timings are still relevant=
 ) ?
=09what was wrong with fbset which I have to keep for the forseeable
future anyway until 2.6 approaches 2.4 reliability ?
>
> So can you and Jak try the attached patch?  It should prevent VGA
> console corruption on insmod and it should eliminate the kobject trace
> messages.
>
Using your 3 recent patches together clears up the green screen problem
and text corruption as well as kobject "badness".

>  int __init rivafb_init(void)
>  {
> -=09int err;
> -=09err =3D pci_module_init(&rivafb_driver);
> -=09if (err)
> -=09=09return err;
> -=09pci_register_driver(&rivafb_driver);
> -=09return 0;
> +=09return pci_module_init(&rivafb_driver);
>  }
>
This will normally return 1, not 0 as before. Is this intended ?