|
From: Antonino D. <ad...@po...> - 2003-01-11 11:45:40
|
On Sat, 2003-01-11 at 19:08, Benjamin Herrenschmidt wrote: > On Sat, 2003-01-11 at 11:16, Antonino Daplas wrote: > > > > Well, yes of course, if a particular hardware feature is quite useful > > and common, then you need something definitive. But what I also want is > > another field which will serve as a private communication channel > > between userspace and driver. Adventurous users/testers can use them to > > turn a unique hardware feature on/off. This is similar to 'Tweak'ing > > utilities common in MS Windows. > > I already do that in some drivers using private ioctl's, though if > what you want is really an additional "feature" affecting a mode > setting, then it makes sense to fit it into fb_var_screeninfo > If you only need to do is turn something on or off, assigning it an ioctl may be too much. The "feature" can be anything, not just a mode setting. Also, you will have fbdev drivers writing their own ioctls just for these "little" features, and each will need to have its own utility written specifically for the driver. If you have an fb_var_screeninfo.tweaks field, you can simply use fbset, and it can be used for all drivers. One can even collect all possible 'hardware' tweaks and create a general fb tweaks utility just by using fbset. Of course, if the feature requires something more than just turning a switch on and off, then an ioctl is more practical. Tony |