Re: [Linux-fbdev-devel] const fb_{fillrect,copyarea,image}?

[James S. <jsi...@in...>]

> drivers/video/fbmem.c:fb_show_logo() initializes only image.dx in each loop
> iteration:
> 
> | for (x = 0; x < num_online_cpus() * (LOGO_W + 8) &&
> |      x < info->var.xres - (LOGO_W + 8); x += (LOGO_W + 8)) {
> |         image.dx = x;
> |         info->fbops->fb_imageblit(info, &image);
> |         done = 1;
> | }

Oh.
 
> > > Of course this means that we have to modify the clipping code, which currently
> > > just modifies the passed structure.
> > 
> > :-( That is done to prevent someone from passing data that is larger than 
> > the framebuffer.
> 
> You can still do clipping without modifying the passed structure, right?

Probable it can be arranged this way.
 
> BTW, is it possible that someone passes data that is larger (except for bugs)?
> We have control over what happens in the kernel. Data passed from userspace is
> a different issue, of course.

Yes. Soon the standard ioctl for a cursor will be truly in place. This 
means cfb_imageblit could be a issue from userland.