Re: [Linux-fbdev-devel] fbmem.c : FBIOGETCMAP

[James S. <jsi...@in...>]

> I'm using 2.53 and I ran into this when running
> fbtest. It looks like a return went missing.
> 
> 	case FBIOGETCMAP:
> 		if (copy_from_user(&cmap, (void *) arg,
> sizeof(cmap)))
> 			return -EFAULT;
> 		fb_copy_cmap(&info->cmap, &cmap, 0);
> 	case FBIOPAN_DISPLAY:
> 
> In 2.4 it looked like this:
> 
> 	case FBIOGETCMAP:
> 		if (copy_from_user(&cmap, (void *) arg,
> sizeof(cmap)))
> 			return -EFAULT;
> 		return (fb->fb_get_cmap(&cmap, 0,
> PROC_CONSOLE(info), info));
> 	case FBIOPAN_DISPLAY:

In the latest code there is a return 0 after fb_copy_cmap. So it is fixed 
with the latest tree.