Re: [Linux-fbdev-devel] fb_pan_display

[James S. <jsi...@ph...>]

> >         if (info->fbops->fb_pan_display) {
> >                 if ((err = info->fbops->fb_pan_display(var, info)))
> >                         return err;
> >                 else
> >                         return -EINVAL;
> >         }
> 
> This is weird. if 0 == info->fbops->fb_pan_display, there's no panning, but it
> does succeed?

Thanks for noticing. That is just plain wrong. I need to fix that 
tomorrow.

> >         info->var.xoffset = var->xoffset;
> >         info->var.yoffset = var->yoffset;
> >         if (var->vmode & FB_VMODE_YWRAP)
> >                 info->var.vmode |= FB_VMODE_YWRAP;
> >         else
> >                 info->var.vmode &= ~FB_VMODE_YWRAP;
> >         return 0;
> > }
> > 
> > Now what I was wondering are these test standard enough that we coudl call
> > this instead of info->fb_ops->fb_pan_display. Several drivers have this
> > test so it would me more code reduction.

That is the idea. fb_pan_display above would always be called.