Re: [Linux-fbdev-devel] gen_set_var() fix?

[Antonino D. <ad...@po...>]

On Wed, 2002-08-28 at 18:00, Jani Monoses wrote:
> James
> Should't gen_set_var set the var in info here as well? (when no check_var present)
> BTW is gen_set_var going to stay in the new API or go away ?
> 
> --- fbgen.c.orig       Wed Aug 28 09:49:45 2002
> +++ fbgen.c     Wed Aug 28 09:57:32 2002
> @@ -36,7 +36,7 @@
> 
>         if (con < 0 || (memcmp(&info->var, var, sizeof(struct fb_var_screeninfo)))) {
>                 if (!info->fbops->fb_check_var) {
> -                       *var = info->var;
> +                       info->var = *var;
>                         return 0;
>                 }
> 
> 
The original code is correct.  It means the driver supports only 1 video
mode, which is the current one in info->var.  

Tony