[Linux-fbdev-devel] Re: cfb_{copyarea,fillrect}()

[James S. <jsi...@tr...>]

> It also adds 64-bit support to cfb_copyarea().

Thanks. Added to BK tree.

> Other comments/notes:
>
>   - Shouldn't cfb_fillrect() use the pseudo_palette in DIRECTCOLOR mode?

??? I thought you had to go threw the DAC to get values.

>   - I think the cfb_*() routines can easily be modified to work for bpp < 8,
>     and for bpp == 24:

It doesn't work for bpp < 4 for you? It should work for those as well. Bpp
24 is a bit more trick if we want to do word align access to the
framebuffer.

>       o initialize src/dst indices to be bit indices instead of byte indices
>       o remove shifts by 3
>       o n is number of bits to copy/fill

Hm. I have to work up so psuedo code to try that idea out.

>   - I think that line length is not guaranteed to be a multiple of
>     sizeof(unsigned long). Hence a different start/end mask per line is
>     possible as well.

Missed that one.