[Linux-fbdev-devel] Bug in fbcon.c penguin drawing

[Geert U. <ge...@li...>]

By accident I stumbled on this...
Since `src' is the penguin logo, we must not use fb_read() to access it.

--- linux-2.4.19-pre9/drivers/video/fbcon.c.orig	Fri Feb 22 16:28:32 2002
+++ linux-2.4.19-pre9/fbcon.c	Sat Jun  1 15:27:31 2002
@@ -2417,7 +2417,7 @@
 		else
 		    dst = fb + y1*line + x/8;
 		for( x1 = 0; x1 < LOGO_LINE; ++x1 )
-		    fb_writeb(fb_readb(src++) ^ inverse, dst++);
+		    fb_writeb(*src++ ^ inverse, dst++);
 	    }
 	    done = 1;
 	}
--- linux-2.5.19/drivers/video/fbcon.c.orig	Mon Apr 29 09:50:07 2002
+++ linux-2.5.19/fbcon.c	Sat Jun  1 15:27:40 2002
@@ -2401,7 +2401,7 @@
 		else
 		    dst = fb + y1*line + x/8;
 		for( x1 = 0; x1 < LOGO_LINE; ++x1 )
-		    fb_writeb(fb_readb(src++) ^ inverse, dst++);
+		    fb_writeb(*src++ ^ inverse, dst++);
 	    }
 	    done = 1;
 	}

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds