Re: [Linux-fbdev-devel] [PATCH] hitfb ported to new api.

[Geert U. <Gee...@so...>]

On Sat, 2 Mar 2002, James Simmons wrote:
> +static struct fb_var_screeninfo hitfb_var __initdata = {
> +	0, 0, 0, 0, 0, 0, 0, 0,
> +	{0, 0, 0}, {0, 0, 0}, {0, 0, 0}, {0, 0, 0},
> +	0, FB_ACTIVATE_NOW, -1, -1, 0, 0, 0, 0, 0, 0, 0, 0,
> +	0, FB_VMODE_NONINTERLACED
>  };

> +static struct fb_fix_screeninfo hitfb_fix __initdata = {
> +	"Hitachi HD64461",(unsigned long) NULL, 0, FB_TYPE_PACKED_PIXELS,
> +	0, FB_VISUAL_TRUECOLOR, 0, 0, 0, 0, (unsigned long) NULL, 0, 
> +	FB_ACCEL_NONE
>  };

Suggestion: use the new-style struct initialization. It's less error-prone, and
you can get rid of the 0/NULL values.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds