[Linux-fbdev-devel] Re: PATCH: FrameBuffer Monitor Functions

[Geert U. <ge...@li...>]

	Hi Carlos,

> > I just noticed some things I overlooked yesterday:
> > 
> >   - The `pixclock' parameter is in ps (picoseconds), not Hz, so the
> >   test
> > 
> >       pixelclock > (fb_info->monspecs.hfmax * htotal)
> > 
> >     is completely wrong! The old code in fbmon.c is correct though,
> >     except for being commented out due to long long arithmetic. IMHO
> >     it would be better to rewrite it so it doesn't use long long
> >     arithmetic.
> > 
> >   - No frame buffer device calls fbmon_valid_timings(). The few that
> >   seem to  call it, have the call protected by #if 0/#endif.
> 
> after all this talking i did it another way (while i'm trying to get the
> vesa specification to autodetect monitor specifications).
> 
> now it checks straight for frequencies...

But it's still not correct: pixelclock is in ps, not Hz.

Please read and understand the old #if 0'd out code...

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds