[Linux-fbdev-devel] Re: PATCH: FrameBuffer Monitor Functions

[Carlos M. D. V. <ca...@em...>]

> 
> I just noticed some things I overlooked yesterday:
> 
>   - The `pixclock' parameter is in ps (picoseconds), not Hz, so the
>   test
> 
>       pixelclock > (fb_info->monspecs.hfmax * htotal)
> 
>     is completely wrong! The old code in fbmon.c is correct though,
>     except for being commented out due to long long arithmetic. IMHO
>     it would be better to rewrite it so it doesn't use long long
>     arithmetic.
> 
>   - No frame buffer device calls fbmon_valid_timings(). The few that
>   seem to  call it, have the call protected by #if 0/#endif.
> 

Hi,
after all this talking i did it another way (while i'm trying to get the
vesa specification to autodetect monitor specifications).

now it checks straight for frequencies...



-- 
"Solo me arrepiento de unos * de menos y unos ++ de sobra"
Carlos Manuel Duclos Vergara