Re: [Linux-fbdev-devel] [PATCH] fbdev fbgen cleanup

[James S. <jsi...@tr...>]

> > The correct fix is to do something like fb_info.node = NODEV;
> 
> And not B_FREE ?
> 
> I am unsure about this, but i notice that in the 2.4.17 kernel + pm3fb, the
> value assigned to .node was -1, which correspond to B_FREE and not NODEV
> (which is 0).

Looking at it your right. It should be B_FREE.

> That said, since it is almost never used, it would maybe be best to move it
> out of the fbdevs and into some of the more generic layers.

I agree. In fact it is already does set it. Form rgeister_framebuffer

fb_info->node = mk_kdev(FB_MAJOR, i);

So why does any fbdev driver touch it?

> Also, since when does the B_FREE or NODEV exists ? I did put the changes into
> a #ifdef kernel 2.5, and kept the -1 for kernels 2.4, but i guess i could
> remove this check altogether if the NODEV was present from the begining. And
> what about 2.2 kernels ?

It is a 2.5.X thing.