[Linux-fbdev-devel] fbgen question

[Jani M. <ja...@as...>]

Hi
I see fbgen_set_var doesn't call set_disp if the accel_flags field is
changed.So if I use fbset -accel it won't change the acceleratoin status.
Most of the drivers(which don't use fbgen) call set_disp form their
set_var.
I could explicitly call set_disp from my routines but I think that would
be uglier.Unless I'm missing something wouldn't such a patch help?

Jani

--- /usr/src/linux/drivers/video/fbgen.c	Wed Dec 19 11:34:55 2001
+++ fbgen.c	Wed Dec 19 11:34:42 2001
@@ -105,7 +105,8 @@
 {
     struct fb_info_gen *info2 = (struct fb_info_gen *)info;
     int err;
-    int oldxres, oldyres, oldbpp, oldxres_virtual, oldyres_virtual, oldyoffset;
+    int oldxres, oldyres, oldbpp, oldxres_virtual, oldyres_virtual, oldyoffset,
+	 oldaccel_flags;

     if ((err = fbgen_do_set_var(var, con == currcon, info2)))
 	return err;
@@ -116,12 +117,14 @@
 	oldyres_virtual = fb_display[con].var.yres_virtual;
 	oldbpp = fb_display[con].var.bits_per_pixel;
 	oldyoffset = fb_display[con].var.yoffset;
+	oldaccel_flags = fb_display[con].var.accel_flags;
 	fb_display[con].var = *var;
 	if (oldxres != var->xres || oldyres != var->yres ||
 	    oldxres_virtual != var->xres_virtual ||
 	    oldyres_virtual != var->yres_virtual ||
 	    oldbpp != var->bits_per_pixel ||
-	    oldyoffset != var->yoffset) {
+	    oldyoffset != var->yoffset ||
+	    oldaccel_flags != var->accel_flags) {
 	    fbgen_set_disp(con, info2);
 	    if (info->changevar)
 		(*info->changevar)(con);