[Linux-fbdev-devel] [PATCH] fb_mmap() holding BKL

[Paul M. <pm...@mv...>]

Hello,

Just a minor cleanup.. in the event of some sanity checking in fb_mmap(), t=
he
BKL is accidentally held on a return.. this trivial patch fixes this issue.
(Against 2.4.14).

Please apply.

Regards,

--=20
Paul Mundt <pm...@mv...>
MontaVista Software, Inc.

--- linux/drivers/video/fbmem.c.orig	Wed Nov 14 15:17:40 2001
+++ linux/drivers/video/fbmem.c	Wed Nov 14 15:17:50 2001
@@ -563,8 +563,10 @@
 		/* memory mapped io */
 		off -=3D len;
 		fb->fb_get_var(&var, PROC_CONSOLE(info), info);
-		if (var.accel_flags)
+		if (var.accel_flags) {
+			unlock_kernel();
 			return -EINVAL;
+		}
 		start =3D fix.mmio_start;
 		len =3D PAGE_ALIGN((start & ~PAGE_MASK)+fix.mmio_len);
 	}