[Linux-fbdev-devel] Re: [PATCH] Port tdfxfb to new-style PCI API

[Paul M. <le...@Ch...>]

On Sat, Jul 28, 2001 at 04:21:17PM -0500, Steven Walter wrote:
> I have created a patch that changes the 3dfx framebuffer driver so that
> it uses the new-style PCI api.  Additionally, it adds the ability to
> pass parameters to the module (previously these were only availible when
> built into the kernel) and makes the indention conformant to
> Coding-Style.
> 
> I've tested it myself as both module and built-in with no problems, but
> you can never test too much.  I'd like to ask adventuresome users of
> this driver to try out my patch, with the hopeful end result of
> inclusion into the kernel.
> 
> The patch is availible from:
> http://www.apex.net/users/trwalter/tdfxfb-patch.gz
> Its 22k compressed (large because of style/indention changes), so I was
> hesitant to post it to the list.
> 
Looks good for the most part, but maybe we could do without the excessive
white space changes?

How about something more like the attached patch?

Regards,

-- 
Paul Mundt <le...@ch...>