From: Sottek, M. J <mat...@in...> - 2001-07-11 18:02:58
|
(XFree removed from cc list, they probably don't care) I don't think we should use the #defines from pci_ids.h since the don't make any sense. The names are apparently the text off the top of the chip. PCI_VENDER_ID_INTEL should be used, but the rest should be named something correct like PCI_DEVICE_ID_I810E_BRIDGE and PCI_DEVICE_ID_I810E_VGA so we know what is going on. Someone can submit a patch to the kernel for pci_ids.h to make the names sane. This is a chipset, not just a PCI device so I810 doesn't fully describe the part. I have no idea what the MC and IG are in the pci_ids.h names. Maybe the fab? Whatever, they are they are not relevant. >Today I uploaded version 1.07 of i810fb. It contains the >i810e patch from Sottek, Matthew J, (sorry, I rewrote it - >it was buggy) Yea, by chance it worked on the i810e but I obviously lost my train of thought half way through :) >Concerning the issue discussion I like the idea of Jeff >Hartmann. I still think Sottek, Matthew J's solution is >just a workaround. Also I prefer high resolutions on >the console. Well I really don't want the current driver showing up in Linus' tree (I hope it didn't happen already). Something that will not work in the configuration used by 99.9% of the i810 owners is not appropriate for Linus' tree. We need to make a default mode that works for everyone. If you want to continue supporting an additional mode that has high resolutions and acceleration that is fine, but it shouldn't be the default. I just don't think supporting modes greater than 1024x768x256 is necessary for the console, and supporting accelerated fb drivers and X drivers concurrently is just a mess waiting to happen. The easiest thing to do is make the unaccelerated version be the one in the kernel sources, and maintain a patch for acceleration support until we find a clean way for it to work together with XFree, or we discover that it isn't worth the effort. >Please, who knows how to put the i180fb source into a >public CVS, or better into the kernel sources, if the >licence question is clear. Please hold off submitting to Linus until the default mode works with X. Anda just said GNU is fine so please make an update with the GNU headers in both the *.c and *.h files. I'm working on the unaccelerated version now, one that can work for everyone with no other kernel or XFree changes. -Matt |