Re: [Linux-fbdev-devel] [PATCH] aty128fb 15/16 bit cleanup

[Michel <mic...@ii...>]

Brad Douglas wrote:
> 
> On 22 Jun 2001 02:16:54 +0200, Michel Dänzer wrote:
> >
> >
> > The attached patch significantly enhances the 16 bit handling of aty128fb.
> > I've achieved this mainly by consequently distinguishing between 'depth'
> > and 'bpp'. I've used these terms for the same meanings as in XFree86 4.x;
> > please let me know if you prefer other terms.
> >
> > While this now works perfectly in X for both depth 15 and 16 as well as in
> > console for fbset -depth 16 -rgba 5,5,5,0 , some colors are wrong for
> > fbset -depth 16 -rgba 5,6,5,0 . It's not clear to me whether the palette
> > for 565 should have 32 or 64 entries.
> >
> >
> > The patch is against 2.4.5-pre3 from Benjamin Herrenschmidt's tree so the
> > offsets are probably off for Linus' tree.
> >
> >
> > BTW I'd love to work on adding Rage128 and Radeon support to the new
> > atyfb.
> >
> >
> > PS: Ah yes, the patch also fixes panning. :)
> 
> Sorry guys.  I've tried to send that patch to Linus several times without it
> ever being accepted.  I should have been more consistently persistent.

No problem, previous versions of the patch weren't as good as I would have
liked anyway. And Ani is merging it into his tree now.


> My surgery ended up taking 8 hours, but it looks like things went better
> than expected and I'll probably never need a transplant!  Now just to
> recover...

Unfortunately, I don't know what this is about, but I'm sure glad it went
fine, all the best!


-- 
Earthling Michel Dänzer (MrCooper)    \   Debian GNU/Linux (powerpc) developer
CS student, Free Software enthusiast   \        XFree86 and DRI project member